Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a few GitHub page updates #527

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

zachmargolis
Copy link
Contributor

No description provided.

- Consistent "GitHub" capitalization
- Update to reference multiple orgs (18f, GSA-TTS)
- Update links to "git-cmp" script
- Nest headings by one level
@zachmargolis zachmargolis requested a review from aduth March 12, 2024 20:01
1. Tag `@github-admins-login` and request to add your GitHub username to the `18f/identity-core` group
1. Tag `@github-admins-login` and request to add your GitHub username to the following teams/orgs:
1. [`18f/identity-core`][18f-identity-core]
2. [`GSA-TTS/identity-core`][gsa-tts-identity-core]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just have people start asking for both at once when they onboard, pending a quick question about permisisons in Slack

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need admins to help with permissions to the organization, but maintainers of the team (including you and me) can add individuals once they're in the organization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping that the org admins have that super permission and can help us skip a step for first-time adds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed ✅

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zachmargolis zachmargolis merged commit 71c93c8 into main Mar 13, 2024
5 checks passed
@zachmargolis zachmargolis deleted the margolis-github-page-updates branch March 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants