add quick notes about mobile device screen recording #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
previously approved these changes
Apr 12, 2024
_articles/product-demo-recordings.md
Outdated
|
|
||
| * On an iPhone or other iOS device, you may need to change your settings to enable screen recordings. Apple provides [instructions on how to do so in their knowledge base](https://support.apple.com/en-us/HT207935). | ||
| * You may want to create an Apple Note to act as a "title slide." This might be a good way to introduce the demo, and provide future viewers with context about what they're about to see. | ||
| * You may want to use a non-production environment such as [dev](https://dev-identity-oidc-sinatra.app.cloud.gov/), especially if your recording would involve identity information (PII). |
There was a problem hiding this comment.
With a link called "dev" I would expect it to go to the IDP in the dev environment, but this links to the sample app, WDYT of updating the title?
Suggested change
| * You may want to use a non-production environment such as [dev](https://dev-identity-oidc-sinatra.app.cloud.gov/), especially if your recording would involve identity information (PII). | |
| * You may want to use a non-production environment, such as starting at a [sample app in the **dev** environment](https://dev-identity-oidc-sinatra.app.cloud.gov/), especially if your recording would involve identity information (PII). |
|
@zachmargolis - ping, can you review again? (also, sorry - i didn't realize you were proposing a change, i made a new commit and apparently overwrote your suggestion 🫠) |
zachmargolis
previously approved these changes
Apr 12, 2024
|
I copied your branch and pushed your commits to a branch within the fork here: #536 |
|
Pushing the copy of your commits got CI to run, so now we can merge either PR |
aduth
reviewed
Apr 15, 2024
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
zachmargolis
approved these changes
Apr 15, 2024
|
CI isn't running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes as a result of this Slack suggestion.
I'm very open to modifications/suggestions, but wanted to capture some quick notes.