Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text stating updates can be made by whatever means necessary #546

Merged
merged 1 commit into from
May 14, 2024

Conversation

Jeremy1026
Copy link
Contributor

@Jeremy1026 Jeremy1026 commented May 14, 2024

Currently the page regarding Secrets and Configuration includes language implying that updates can be made by editing the secrets file in s3 by downloading, editing, and uploading. This is not recommended, users should use the app-s3-secret script to make edits. So this PR removes that language.

Conversation in Slack regarding this change

Copy link
Contributor

@Sgtpluck Sgtpluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@ajfarkas ajfarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to include instructions to use app-s3-secret?

@Jeremy1026
Copy link
Contributor Author

Would it make sense to include instructions to use app-s3-secret?

There is instruction for how to use the script directly below.

@Jeremy1026 Jeremy1026 merged commit 293736d into main May 14, 2024
5 checks passed
@Jeremy1026 Jeremy1026 deleted the jcurcio/update-secrets-and-config-page branch May 14, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants