Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-13016: v2 remove oncall by request #553

Closed
wants to merge 2 commits into from
Closed

LG-13016: v2 remove oncall by request #553

wants to merge 2 commits into from

Conversation

jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented May 21, 2024 •
edited
Loading

@jc-gsa jc-gsa requested review from zachmargolis and a team May 21, 2024 20:55
zachmargolis
zachmargolis previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you could also remove product: true so that the requirement doesn't apply? It doesn't affect anything visually on the page

@jc-gsa jc-gsa requested a review from zachmargolis May 21, 2024 21:41
@jc-gsa jc-gsa closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis Awaiting requested review from zachmargolis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jc-gsa @zachmargolis