Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Melba to sprint teams #554

Merged
merged 2 commits into from
May 28, 2024
Merged

Add Melba to sprint teams #554

merged 2 commits into from
May 28, 2024

Conversation

Sgtpluck
Copy link
Contributor

This change:

  • Adds Team Melba
  • Updates slack links to https://gsa.enterprise.slack.com

@Sgtpluck Sgtpluck requested review from zachmargolis and aduth May 22, 2024 13:09
aduth
aduth previously approved these changes May 22, 2024
@aduth
Copy link
Contributor

aduth commented May 22, 2024

LGTM

zachmargolis
zachmargolis previously approved these changes May 22, 2024
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slack_channel_name: login-team-mary
readme: https://docs.google.com/document/d/1MVybeUqkBIYz13H2eTi2X0EqW_IhA87ZRq3g-xNWkOc/edit

- name: Melba
namesake_markdown: "[Melba Roy Mouton](https://en.wikipedia.org/wiki/Melba_Roy_Mouton), Head Mathematician, Head Computer Programmer, instructor and Program Production Chief at NASA whose work tracked early Echo satellites in orbit."
focus_area: Protocols and RISC API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of forcing you to get another review, would it be worth specifying OIDC and SAML for "protocols"?

Suggested change
focus_area: Protocols and RISC API
focus_area: Protocols like OpenID Connect, SAML and RISC API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's no problem :) fixed in 5319827

@Sgtpluck Sgtpluck dismissed stale reviews from zachmargolis and aduth via 5319827 May 28, 2024 12:21
@Sgtpluck Sgtpluck requested a review from zachmargolis May 28, 2024 12:22
@Sgtpluck Sgtpluck merged commit eeff3d1 into main May 28, 2024
5 checks passed
@Sgtpluck Sgtpluck deleted the dmm/add-melba branch May 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants