-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SQL style guide #555
Conversation
@zachmargolis - LGTM, but a question: Would we want to link to external style guides, as references? |
Yes! I skimmed a few but hadn't found any that seemed like good baselines, do you have any suggestions? |
@zachmargolis - I don't offhand, but I will reach-out to a few former colleagues and friends to see if any of them have suggestions. Maybe we can merge this as-is, and we'll plan to add more as we identify some examples? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there meant to be content included in the changes here? I only see a subcategory
metadata added.
d'oh! updated in c580932 |
@aduth - Amazing catch! @zachmargolis - I honestly thought this was "let's start the smallest possible thing and iterate" so I didn't question 😅 @zachmargolis - A few possible "best practices" that I've learned about... |
Thanks! I'll take a closer look at those and see what we can reference/incorporate! |
Starts a small SQL style guide! Like it says inside, it's not enforced, but I would like to start norming as a team on these!
I found that Gitlab has a style guide which I skimmed for reference.
I would like to find a way to use an automated tool like sqlfluff that they mention, but currently, it would not work for our codebases that have SQL embedded inside ruby files. I've got some ideas for how we can cobble something togethe.