Redo: Override GSA-TTS .allstar config #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # AC-2 (part k): cans, checks, and branch protection policies are enforced | ||
| # configurations through the GSA-TTS Github Allstar implementation. | ||
| # SI-7 Software, Firmware, and Information Integrity | ||
| optConfig: |
There was a problem hiding this comment.
Should we be concerned about drift if this means changes in the upstream rules won't be captured here?
aduth
approved these changes
May 30, 2024
There was a problem hiding this comment.
Not entirely certain we need this pending #560 (comment), but would expect to be safe regardless
|
Closing, looks like we got a violation as expected: #519 (comment) that shows only one violation (instead of 2), so this is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies in entire config so that we can override one line of it, follow-up to #560