Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use link helper to generate GitHub article URL #614

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Use link helper to generate GitHub article URL #614

merged 1 commit into from
Oct 22, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 22, 2024

Updates Cloud.gov Pages article to use the {% link %} helper to generate a URL to the GitHub article, so that it works correctly in local and preview environments.

Addresses #613 (comment)

Testing Instructions:

  1. Go to https://federalist-7d0b2b76-42fc-4df1-9825-8c3cd77e0a15.sites.pages.cloud.gov/preview/gsa-tts/identity-handbook/aduth-cloud-gov-link-helper/articles/cloud-gov-pages.html
  2. Take note of the URL hostname in your address bar
  3. Click "request access to be added"
  4. Observe that you're still on the same URL hostname from Step 2

@aduth aduth requested a review from zachmargolis October 22, 2024 20:51
@aduth aduth mentioned this pull request Oct 22, 2024
Merged
@aduth aduth merged commit ba1042b into main Oct 22, 2024
5 checks passed
@aduth aduth deleted the aduth-cloud-gov-link-helper branch October 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @zachmargolis