Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics api #73

Merged
merged 17 commits into from
Oct 31, 2023
Merged

Analytics api #73

merged 17 commits into from
Oct 31, 2023

Conversation

nathan-moore-97
Copy link
Contributor

@nathan-moore-97 nathan-moore-97 commented Oct 11, 2023

For this feature, we will need to add a couple variables to the credentials collection.
analytics_root (str) : String ID of the Google Drive object the Analytics will be written to. (ex. Rekrewt Data Dev)
analytics_property_id (int) : ID of the property to run analytics on

We will also need to set an enviornment variable to turn on the Analytics API.
ANALYTICS (bool): default is false.

Copy link
Contributor

@dzaslavskiy dzaslavskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict needs to be resolved. unit tests should not fail. review the diff to ensure no inadvertent changes where committed.

gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/export_api.py Outdated Show resolved Hide resolved
gdrive/export_client.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
gdrive/sheets_client.py Outdated Show resolved Hide resolved
gdrive/sheets_client.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Fixed Show fixed Hide fixed
gdrive/analytics_api.py Fixed Show resolved Hide resolved
gdrive/analytics_api.py Fixed Show fixed Hide fixed
@nathan-moore-97 nathan-moore-97 dismissed dzaslavskiy’s stale review October 18, 2023 18:06

Completed requested changes

gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_client.py Outdated Show resolved Hide resolved
gdrive/analytics_client.py Outdated Show resolved Hide resolved
gdrive/export_api.py Outdated Show resolved Hide resolved
gdrive/sheets_client.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Outdated Show resolved Hide resolved
gdrive/sheets_client.py Outdated Show resolved Hide resolved
gdrive/analytics_api.py Dismissed Show dismissed Hide dismissed
@nathan-moore-97 nathan-moore-97 merged commit f7a218b into GSA-TTS:main Oct 31, 2023
5 checks passed
@nathan-moore-97 nathan-moore-97 deleted the analytics_api branch November 17, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants