Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an egress proxy module #53

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Create an egress proxy module #53

merged 7 commits into from
Oct 10, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Oct 10, 2024

🎫 Addresses issue: #42

closes #42

🛠 Summary of changes

📜 Testing Plan

Implemented and deployed an app using this module: GSA-TTS/continuous-assessment-poc#45

Deploy action: https://github.com/GSA-TTS/continuous-assessment-poc/actions/runs/11277289453

@rahearn rahearn requested review from mogul, asteel-gsa and a team October 10, 2024 16:26
zjrgov
zjrgov previously approved these changes Oct 10, 2024
README.md Show resolved Hide resolved
egress_proxy/prepare-proxy.sh Show resolved Hide resolved
egress_proxy/variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[I feel like my IQ has dropped 100 points since I wrote this... Really proud of the result, just not sure if I'd have the grit to figure it out if I had to today.]

I think there was a Mermaid diagram in the source repo... Am I misremembering? Or is it in the cg-egress-proxy repo? Either way I think it should be included here too. Other than that, these are good additions, and I wouldn't hold up the merge for wont of the diagram.

@rahearn
Copy link
Contributor Author

rahearn commented Oct 10, 2024

I think there was a Mermaid diagram in the source repo...

you're not misremembering, but it is the exact mermaid diagram that's in cg-egress-proxy's README. I'm going to merge this and we'll improve docs/diagrams in due course

@rahearn rahearn merged commit bc66708 into main Oct 10, 2024
21 checks passed
@rahearn rahearn deleted the egress-proxy branch October 10, 2024 19:42
@mogul
Copy link
Contributor

mogul commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate FAC Egress Proxy into Shared Modules
3 participants