Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build test #102

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add build test #102

merged 1 commit into from
Jul 22, 2024

Conversation

wesley-dean-gsa
Copy link
Contributor

Changes proposed in this pull request:

Per #100, this will add a basic build test. That is, it will attempt to build the site. If the site won't build, the test will fail.

Note: there is a commented-out npm run tests as the package.json shows that the test is designed to fail immediately as there are no tests defined.

security considerations

This does not have an impact on the security of the site or the repo.

@wesley-dean-gsa
Copy link
Contributor Author

We expect the Snyk test to fail; once #101 is merged and this branch is updated, that'll go away.

@wesley-dean-gsa wesley-dean-gsa linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link
Contributor

@debjudy debjudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve 👍

@wesley-dean-gsa wesley-dean-gsa merged commit 394450e into main Jul 22, 2024
5 of 6 checks passed
@wesley-dean-gsa wesley-dean-gsa deleted the 100-build-integration-tests branch July 22, 2024 15:39
@wesley-dean-gsa wesley-dean-gsa restored the 100-build-integration-tests branch July 30, 2024 13:59
@wesley-dean-gsa wesley-dean-gsa deleted the 100-build-integration-tests branch August 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include build / integration tests
2 participants