Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to make current #186

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Update README to make current #186

merged 2 commits into from
Aug 28, 2024

Conversation

wesley-dean-gsa
Copy link
Contributor

Changes proposed in this pull request

This updates the README documentation to show how to interact with the site while removing the Netlify references.

security considerations

None. Just a documentation change.

@wesley-dean-gsa wesley-dean-gsa requested a review from a team as a code owner August 27, 2024 18:19
Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.1s
✅ BASH shellcheck 1 0 0.1s
✅ BASH shfmt 1 0 0 0.24s
⚠️ CSS scss-lint 2 1 2.86s
✅ JAVASCRIPT prettier 6 0 0 1.11s
✅ JSON jsonlint 7 0 0.21s
✅ JSON npm-package-json-lint yes no 0.5s
✅ JSON prettier 7 0 0 1.23s
✅ JSON v8r 7 0 11.97s
⚠️ MARKDOWN markdownlint 20 0 10 2.01s
⚠️ MARKDOWN markdown-link-check 20 1 8.49s
✅ MARKDOWN markdown-table-formatter 20 0 0 0.38s
✅ REPOSITORY checkov yes no 16.82s
✅ REPOSITORY gitleaks yes no 0.2s
✅ REPOSITORY git_diff yes no 0.24s
✅ REPOSITORY grype yes no 15.04s
✅ REPOSITORY secretlint yes no 2.64s
✅ REPOSITORY trivy yes no 8.82s
✅ REPOSITORY trivy-sbom yes no 1.6s
✅ REPOSITORY trufflehog yes no 4.18s
⚠️ SPELL cspell 20 1 2.86s
✅ YAML prettier 14 0 0 1.27s
✅ YAML v8r 11 0 17.83s
✅ YAML yamllint 14 0 0.51s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//update_readme/

Results for URL: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//update_readme/

• Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.68:1. Recommendation: change background to #63686c.
├── WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
├── #main-content > section:nth-child(3) > div > div > div:nth-child(2) > p
└──

For over 50 years, GSA has been...

1 Errors

Copy link
Contributor

@debjudy debjudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@wesley-dean-gsa wesley-dean-gsa merged commit 4d8052d into main Aug 28, 2024
5 checks passed
@wesley-dean-gsa wesley-dean-gsa deleted the update_readme branch August 28, 2024 14:54
Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//update_readme/

Error: TimeoutError: Timed out after 30000 ms while waiting for the WS endpoint URL to appear in stdout!
at ChromeLauncher.launch (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/puppeteer-core/lib/cjs/puppeteer/node/ProductLauncher.js:147:23)
at async setBrowser (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/lib/pa11y.js:132:19)
at async runPa11yTest (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/lib/pa11y.js:64:2)
at async pa11y (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/lib/pa11y.js:35:18)
at async runProgram (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/bin/pa11y.js:135:19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants