Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

171 update jointts urls #195

Merged
merged 9 commits into from
Aug 29, 2024
Merged

171 update jointts urls #195

merged 9 commits into from
Aug 29, 2024

Conversation

debjudy
Copy link
Contributor

@debjudy debjudy commented Aug 28, 2024

Changes proposed in this pull request

  • update jointts urls to link to new site instead of out to join.tts.gsa.gov

security considerations

[Note the any security considerations here, or make note of why there are none]

Testing one URL change
@debjudy debjudy requested review from a team as code owners August 28, 2024 20:31
Copy link

github-actions bot commented Aug 28, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.05s
✅ BASH shellcheck 1 0 0.14s
✅ BASH shfmt 1 0 0 0.25s
⚠️ CSS scss-lint 2 1 3.09s
✅ JAVASCRIPT prettier 6 0 0 1.07s
✅ JSON jsonlint 7 0 0.2s
✅ JSON npm-package-json-lint yes no 0.45s
✅ JSON prettier 7 0 0 1.25s
✅ JSON v8r 7 0 11.28s
⚠️ MARKDOWN markdownlint 21 0 10 2.14s
⚠️ MARKDOWN markdown-link-check 21 9 16.3s
✅ MARKDOWN markdown-table-formatter 21 0 0 0.34s
✅ REPOSITORY checkov yes no 14.91s
✅ REPOSITORY gitleaks yes no 0.23s
✅ REPOSITORY git_diff yes no 0.24s
✅ REPOSITORY grype yes no 13.94s
✅ REPOSITORY secretlint yes no 2.52s
✅ REPOSITORY trivy yes no 7.72s
✅ REPOSITORY trivy-sbom yes no 1.2s
✅ REPOSITORY trufflehog yes no 4.14s
⚠️ SPELL cspell 21 15 4.28s
✅ YAML prettier 14 0 0 1.33s
✅ YAML v8r 11 0 11.28s
✅ YAML yamllint 14 0 0.72s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

No issues found!

Update URLs
Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

Error: TimeoutError: Timed out after 30000 ms while waiting for the WS endpoint URL to appear in stdout!
at ChromeLauncher.launch (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/puppeteer-core/lib/cjs/puppeteer/node/ProductLauncher.js:147:23)
at async setBrowser (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/lib/pa11y.js:132:19)
at async runPa11yTest (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/lib/pa11y.js:64:2)
at async pa11y (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/lib/pa11y.js:35:18)
at async runProgram (/home/runner/work/tts.gsa.gov/tts.gsa.gov/node_modules/pa11y/bin/pa11y.js:135:19)

Removed extra period.
Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

No issues found!

Add subnav
Fix URL
Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

No issues found!

Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

No issues found!

Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

No issues found!

narumigsa
narumigsa previously approved these changes Aug 29, 2024
Copy link
Contributor

@narumigsa narumigsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wesley-dean-gsa wesley-dean-gsa dismissed narumigsa’s stale review August 29, 2024 17:21

The merge-base changed after approval.

Copy link

Pa11y testing results ``` Welcome to Pa11y

Running Pa11y on URL https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov//171-update-jointts-urls/

No issues found!

@wesley-dean-gsa wesley-dean-gsa merged commit 7a96d2d into main Aug 29, 2024
13 checks passed
@wesley-dean-gsa wesley-dean-gsa deleted the 171-update-jointts-urls branch August 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants