1434 js console errors

.github/ISSUE_TEMPLATE/bug.md

@@ -0,0 +1,29 @@
+---
+name: Bug
+about: Description of a bug or defect
+labels:
+  - bug
+---
+
+<!-- description of the issue, please including any relevant information:
+  - version
+  - environment
+  - component
+  - error logs
+  - stack trace -->
+
+## How to reproduce
+
+1. Description of steps to reproduce the issue.
+
+## Expected behavior
+
+<!-- description of what you expected to happen. -->
+
+## Actual behavior
+
+<!-- description of what actually happened. -->
+
+## Screenshots
+
+<!-- images showing the issue, if needed -->

.github/ISSUE_TEMPLATE/user-story.md

@@ -0,0 +1,25 @@
+---
+name: User story
+about: Story about a new user feature
+title: ''
+labels: ''
+assignees: ''
+---
+## User Story
+
+As a [role], I want to [goal/desire] so that [benefit/reason].
+
+## Acceptance Criteria
+
+1. Given [context], when [action], then [result].
+2. Given [context], when [action], then [result].
+3. ...
+
+## Tasks:
+- [ ] Task 1
+- [ ] Task 2
+- [ ] ...
+
+## Background
+
+[Any helpful contextual notes or links to artifacts/evidence, if needed]

.github/pull_request_template.md

@@ -1,13 +1,27 @@
-## Description of changes
+### Description
 
-## Link to issue
-Issue Number: 
+[Provide a brief description of the changes implemented in this pull request.]
 
-# Screenshots / Demo
-_Include steps a user would need to make in order to exercise the new functionality._
+### Related Issues
+
+[Reference any related issues, if applicable.]
+
+### Changes Made
+
+- [List the specific changes made in bullet points.]
+
+### Screenshots (if applicable)
+
+[Include screenshots to visually demonstrate changes, if relevant.]
 
 # Checklist
+- [ ] PR is assigned to a project: Challenge_gov Board
+- [ ] PR is assigned to a milestone: current sprint
+- [ ] PR is assigned a reviewer, and requires code review and approval by a teammate
 - [ ] New functionality is tested and all tests are green
+- [ ] I have added unit tests for new functionality or updated existing tests for changes.
+- [ ] I have updated the documentation/README accordingly, if necessary.
 - [ ] If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
-- [ ] If needed, README is up to date
 - [ ] If applicable, Controllers modified contain appropriate authorization plugs
+- [ ] This PR has been reviewed by at least one other team member.
+

.tool-versions

@@ -1,4 +1,4 @@
 elixir 1.12.3
 erlang 23.3.2
 nodejs 18.17.1
-yarn 1.22.5
+yarn 1.22.19

assets/client/src/components/ChallengeAnnouncement.js

@@ -1,10 +1,13 @@
 import React from 'react';
-import moment from 'moment';
 import {formatDate, daysInMinutes, formatDateTime} from "../helpers/phaseHelpers"
 
 export const ChallengeAnnouncement = ({challenge}) => {
   const checkAnnouncementDate = ({announcement_datetime}) => {
-    return moment().diff(announcement_datetime, 'minutes') <= daysInMinutes(14)
+
+    let now =  new Date();
+   let announcementDate = new Date(announcement_datetime);
+   let diffInMinutes = (now - announcementDate) / (1000 * 60);
+   return diffInMinutes <= daysInMinutes(14)
   }
 
   const renderAnnouncement = ({header, body}) => {

assets/client/src/components/ChallengeDetails.js

@@ -1,5 +1,4 @@
 import React, { useContext, useEffect, useState } from 'react'
-import moment from "moment"
 import { stripHtml } from "string-strip-html";
 import { Tooltip } from 'reactstrap';
 import NumberFormat from 'react-number-format';
@@ -30,22 +29,50 @@ export const ChallengeDetails = ({challenge, challengePhases, preview, print, ta
   const toggleShareTooltip = () => setShareTooltipOpen(!shareTooltipOpen)
 
   const renderEndDate = (date) => {
-    const fiveDaysFromNow = moment().add(5,'d').utc().format()
-    const withinFiveDays = moment(date).diff(fiveDaysFromNow) <= 0
 
-    if (date >  moment().utc().format()) {
+    let localTimeZone = Intl.DateTimeFormat().resolvedOptions().timeZone; 
+
+    let formatLocalDateTime = (date) => {
+      let dateObj = new Date(date);    
+      let dateOptions = { year: 'numeric', month: '2-digit', day: '2-digit', timeZone: localTimeZone };
+      let timeOptions = { hour: '2-digit', minute: '2-digit', hour12: true, timeZone: localTimeZone };
+      let formattedDate = dateObj.toLocaleDateString('en-US', dateOptions);
+      let formattedTime = dateObj.toLocaleTimeString('en-US', timeOptions);    
+      return `${formattedDate} ${formattedTime}`;
+    }   
+
+    const fiveDaysFromNow = () => {
+      let now = new Date();
+      now.setDate(now.getDate() + 5);
+      let utcDate = new Date(Date.UTC(now.getFullYear(), now.getMonth(), now.getDate(), now.getHours(), now.getMinutes(), now.getSeconds()));
+      return utcDate.toDateString(); 
+    }
+
+    const withinFiveDays = (date) => {
+      let givenDate = new Date(date);
+      let now = new Date();
+      let futureDate = new Date(fiveDaysFromNow());
+      return givenDate <= futureDate;
+    } 
+
+    let getUTCNow = () =>  {
+      let now = new Date();
+      return now.toISOString();
+    }
+
+    if (date >  getUTCNow()) {
       return (
         <div className="item">
           <p className="info-title">Open until:</p>
-          <p>{moment(date).local().format('L LT')}</p>
-          { withinFiveDays && <p className="date-qualifier">Closing soon</p> }
+          <p>{formatLocalDateTime(date)}</p>
+          { withinFiveDays() && <p className="date-qualifier">Closing soon</p> }
         </div>
       )
     } else {
       return (
         <div className="item">
           <p className="info-title">Closed on:</p>
-          <p>{moment(date).local().format('L LT')}</p>
+          <p>{formatLocalDateTime(date)}</p>
         </div>
       )
     }
@@ -94,7 +121,7 @@ export const ChallengeDetails = ({challenge, challengePhases, preview, print, ta
           <div className="follow-tooltip__section">
             <h4>Follow challenge as guest</h4>
             <p>Receive challenge updates to your email. No sign-in required</p>
-            <a href={preview ? null : challenge.gov_delivery_topic_subscribe_link}>
+            <a href={preview ? "#" : `${encodeURIComponent(challenge.gov_delivery_topic_subscribe_link)}`}>
               <button className="follow-tooltip__button">Follow challenge</button>
             </a>
           </div>
@@ -323,7 +350,7 @@ export const ChallengeDetails = ({challenge, challengePhases, preview, print, ta
                   <div className="logos">
                     <img
                       className="agency-logo"
-                      src={imageBase + challenge.agency_logo}
+                      src={`${imageBase}${encodeURIComponent(challenge.agency_logo)}`}
                       alt={`Agency logo for ${challenge.agency_name}`}                    
                     />
 
@@ -377,7 +404,7 @@ export const ChallengeDetails = ({challenge, challengePhases, preview, print, ta
                 </div>
               }
               {!print &&
-                <a className="follow__btn" href={apiUrl + `/public/previews/challenges?challenge=${challenge.uuid}&print=true`} target="_blank">
+                <a className="follow__btn" href={`${apiUrl}/public/previews/challenges?challenge=${encodeURIComponent(challenge.uuid)}&print=true`} target="_blank" rel="noopener noreferrer">
                   <span className="details__btn">
                       <svg className="usa-icon" aria-hidden="true" focusable="false" role="img"
                            style={{fill: "#FA9441", height: "21px", width: "21px", position: "relative", top: "5px", right: "5px"}}>

assets/client/src/components/ChallengeTile.js

@@ -1,17 +1,23 @@
 import React, {useContext} from 'react'
 import { Link } from "react-router-dom";
-import moment from "moment"
 import {getCurrentPhase, getNextPhase, phaseNumber, formatDateTime, formatTime, isSinglePhase, isPhaseless, daysInMinutes} from "../helpers/phaseHelpers"
 import {truncateString} from '../helpers/stringHelpers'
 import { ApiUrlContext } from '../ApiUrlContext'
 
 export const ChallengeTile = ({challenge, preview}) => {
   const { publicUrl, imageBase } = useContext(ApiUrlContext)
 
+  let diffMinutes = (d) =>{
+    let now = new Date(); 
+    let date = new Date(d);
+    return (now - date) / (1000 * 60)
+  }
+
   const renderTags = ({is_archived, start_date, end_date, announcement_datetime}) => {
-    const startDateDiff = moment().diff(start_date, 'minutes')
-    const endDateDiff = moment().diff(end_date, 'minutes')
-    const announcementDateDiff = moment().diff(announcement_datetime, 'minutes')
+
+    const startDateDiff = diffMinutes(start_date);
+    const endDateDiff = diffMinutes(end_date);
+    const announcementDateDiff = diffMinutes(announcement_datetime);
 
     let tags = []
 
@@ -40,8 +46,8 @@ export const ChallengeTile = ({challenge, preview}) => {
 
   const renderDate = (challenge) => {
     const {start_date, end_date, phases} = challenge
-    const startDateDiff = moment().diff(start_date, 'minutes')
-    const endDateDiff = moment().diff(end_date, 'minutes')
+    const startDateDiff = diffMinutes(start_date)
+    const endDateDiff = diffMinutes(end_date)
 
     if (isPhaseless(challenge)) {
       return handlePhaselessChallengeDate(challenge)
@@ -73,8 +79,8 @@ export const ChallengeTile = ({challenge, preview}) => {
 
   // TODO: This is potentially temporary until the importer handles adding phases to imported challenges
   const handlePhaselessChallengeDate = ({start_date, end_date}) => {
-    const startDateDiff = moment().diff(start_date, 'minutes')
-    const endDateDiff = moment().diff(end_date, 'minutes')
+    const startDateDiff = diffMinutes(start_date)
+    const endDateDiff = diffMinutes(end_date)
 
     if (startDateDiff < 0) {
       return `Opens on ${formatDateTime(start_date)}`
@@ -109,7 +115,7 @@ export const ChallengeTile = ({challenge, preview}) => {
         <div className="agency_image_wrapper">
           <img
             className="agency-logo"
-            src={imageBase + challenge.agency_logo}
+            src={`${imageBase}${encodeURIComponent(challenge.agency_logo)}`}
             alt={truncateString(`Agency Logo: ${challenge.agency_name}`, 90)}
           />
         </div>
@@ -128,7 +134,7 @@ export const ChallengeTile = ({challenge, preview}) => {
       <div className="image_wrapper">
         <img
             className="agency-logo"
-            src={imageBase + challenge.agency_logo}
+            src={`${imageBase}${encodeURIComponent(challenge.agency_logo)}`}
             alt={truncateString(`Agency Logo: ${challenge.agency_name}`, 90)}
         />
       </div>
@@ -138,7 +144,7 @@ export const ChallengeTile = ({challenge, preview}) => {
   return (
     challenge ? (
       <div key={challenge.id} className="challenge-tile card">
-        <a href={challengeTileUrl(challenge, preview)} target={challenge.external_url ? "_blank" : ""} aria-label="">
+        <a href={encodeURI(challengeTileUrl(challenge, preview))} target={challenge.external_url ? "_blank" : ""} aria-label="">
           {renderTileLogo()}
           <div className="challenge-tile__text-wrapper">
             <h2 className="challenge-tile__title test" aria-label="" style={{ textAlign: 'left', paddingLeft: '20px', paddingTop: '20px', lineHeight: '30px' }}>{truncateString(challenge.title, 90)}</h2>

assets/client/src/components/ChallengeTiles.js

@@ -1,5 +1,4 @@
 import React, { useState, useEffect } from 'react';
-import moment from 'moment';
 import { ChallengeTile } from './ChallengeTile';
 
 const dateAddedOptions = [
@@ -75,6 +74,15 @@ export const ChallengeTiles = ({ data, loading, isArchived, selectedYear, handle
   const [keyword, setKeyword] = useState('');
   const [filteredChallenges, setFilteredChallenges] = useState([]);
 
+  const isBetween = (date, startDate, endDate) => {
+
+    let dateObj = new Date(date);
+    let startDateObj = new Date(startDate);
+    let endDateObj = new Date(endDate);
+    return dateObj >= startDateObj && dateObj < endDateObj;
+
+  }
+
  useEffect(() => {
   try {
     if (data && data.collection) {
@@ -88,26 +96,32 @@ export const ChallengeTiles = ({ data, loading, isArchived, selectedYear, handle
       }
 
       if (dateAdded) {
-        const now = moment();
-        let fromDate = now.clone().subtract(1, "years"); 
+
+        const now = new Date(); 
+        let fromDate = new Date(now);
+        fromDate.setFullYear(fromDate.getFullYear() -1); 
+
 
         switch (dateAdded) {
           case "Past Week":
-            fromDate = now.clone().subtract(7, "days");
+            fromDate = new Date(now);
+            fromDate.setDate(fromDate.getDate() -7);
             break;
           case "Past Month":
-            fromDate = now.clone().subtract(1, "months");
+            fromDate = new Date(now);
+            fromDate.setMonth(fromDate.getMonth() -1);
             break;
           case "Past 90 Days":
-            fromDate = now.clone().subtract(90, "days");
+            fromDate = new Date(now);
+            fromDate.setDate(fromDate.getDate() -90);
             break;
           default:
             break;
         }
 
         filtered = filtered.filter((challenge) => {
-          const challengeDate = moment(challenge.inserted_at);
-          return challengeDate.isBetween(fromDate, now, null, "[)");
+          const challengeDate = new Date(challenge.inserted_at);
+          return isBetween(challengeDate, fromDate, now);
         });
       }
 
@@ -116,30 +130,35 @@ export const ChallengeTiles = ({ data, loading, isArchived, selectedYear, handle
       }
 
       if (lastDay) {
-        const now = moment();
+        const now = new Date();
         let toDate;
 
         switch (lastDay) {
           case "Next Week":
-            toDate = now.clone().add(7, "days");
+            toDate = new Date(now);
+            toDate.setDate(toDate.getDate() +7);
             break;
           case "Next Month":
-            toDate = now.clone().add(1, "months");
+            toDate = new Date(now);
+            toDate.setMonth(toDate.getMonth()+1);
             break;
           case "Next 90 days":
+            toDate = new Date(now);
             toDate = now.clone().add(90, "days");
             break;
           case "Within Year":
-            toDate = now.clone().add(1, "years");
+            toDate = new Date(now);
+            toDate.setFullYear(toDate.getFullYear()+1);
             break;
           default:
-            toDate = now.clone().add(1, "years");
+            toDate = new Date(now);
+            toDate.setFullYear(toDate.getFullYear()+1);
             break;
         }
 
       filtered = filtered.filter((challenge) => {
-          const challengeEnd = moment(challenge.end_date);
-          return challengeEnd.isBetween(now, toDate, null, "[)");
+          const challengeEnd = new Date(challenge.end_date);
+          return isBetween(challengeEnd, now, toDate);
         });
       }
 
@@ -296,7 +315,8 @@ export const ChallengeTiles = ({ data, loading, isArchived, selectedYear, handle
 
   const renderYearFilter = () => {
   const startYear = 2010;
-  const currentYear = moment().year();
+  let year = new Date();
+  const currentYear = year.getFullYear();
   const range = (start, stop, step) => Array.from({ length: (stop - start) / step + 1 }, (_, i) => start + (i * step));
   const years = range(currentYear, startYear, -1);