Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javascript console errors - challenge.gov #1434 #1436

Merged
merged 1 commit into from
Sep 23, 2024
Merged

javascript console errors - challenge.gov #1434 #1436

merged 1 commit into from
Sep 23, 2024

Conversation

kkrug
Copy link
Contributor

@kkrug kkrug commented Sep 23, 2024

Description

Add validation to prevent javascript console erros

Related Issues

GSA/challenges-and-prizes#2025

Changes Made

  • Updated index.js to add validation

Screenshots (if applicable)

N/A

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.

@kkrug kkrug added the javascript Pull requests that update Javascript code label Sep 23, 2024
@kkrug kkrug added this to the Sprint 09/24/24 milestone Sep 23, 2024
@kkrug kkrug linked an issue Sep 23, 2024 that may be closed by this pull request
javascript console errors - challenge.gov #1434
Closed
@kkrug kkrug requested a review from jdonis September 23, 2024 18:18
@jdonis jdonis merged commit 6bb10fa into staging Sep 23, 2024
5 checks passed
@jdonis jdonis deleted the 1434-js-console-errors branch September 23, 2024 18:43
@jdonis jdonis mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonis jdonis jdonis approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
Sprint 09/24/24
Development

Successfully merging this pull request may close these issues.

javascript console errors - challenge.gov
2 participants
@kkrug @jdonis