Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation Form: Scale Type #69

Closed
36 of 46 tasks
r-bartlett-gsa opened this issue Jul 26, 2024 · 5 comments
Closed
36 of 46 tasks

Evaluation Form: Scale Type #69

r-bartlett-gsa opened this issue Jul 26, 2024 · 5 comments
Assignees

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Jul 26, 2024

User story

As a challenge manager, in order to create fair and accurate scoring form, I would like to have an option to either apply weights to criteria scores or to use point scale.

Acceptance criteria:

  • A challenge manager can indicate if they want to use Point Scale or Weighted Scale for their evaluation form
  • When "weighted scale" option is selected:
    • Criteria Points / Weight field value is used as a weight value for the criteria (Evaluation Score Calculation #71 )
    • When a challenge manager saves the form, the system validates if inputted weights for all criteria add up to 100%
      • If a total weight for all criteria is not 100%, a form an error message is displayed
  • When "point scale" option is selected:
    • Criteria Points / Weight field value is used to indicate the max score value for the criteria (Evaluation Score Calculation #71 )
    • Criteria point values for all criteria can add up to any value

Development tasks:

  • Task 1
  • Task 2

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Usability testing: mobile and desktop (Tracy or Marni)
  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa r-bartlett-gsa changed the title Evaluation Form: Scoring Criteria Category Weights Evaluation Form: Scoring Criteria Weights Aug 2, 2024
@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Aug 2, 2024

Image

@r-bartlett-gsa r-bartlett-gsa changed the title Evaluation Form: Scoring Criteria Weights Evaluation Form: Scale Type Sep 6, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 10/08/24 milestone Sep 25, 2024
@cpreisinger cpreisinger self-assigned this Oct 14, 2024
@r-bartlett-gsa
Copy link
Member Author

Moving user feedback from #61 to this appropriate user story:

  • None of Scale Type options should be selected by default

@mhotch24
Copy link

mhotch24 commented Nov 7, 2024

@r-bartlett-gsa @TCKapGrp
A11y and Cross Browser testing completed and passed.

@TCKapGrp
Copy link

TCKapGrp commented Nov 7, 2024

@r-bartlett-gsa

QA Feedback:
1 - You can type a very large number into the criteria points per the AC but if you only see the first four characters. If a person does a copy and paste a few times or some other error in typing, there is no way to validate the data.

2 - I typed in a VERY long string of numbers: 192222900000000000000222222020202020202020202020200202020202020200202020202020

and when saving got this error:

Image

when I changed it to "20" no error was recorded.

@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Nov 7, 2024

@stepchud Please address the following feedback:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants