Evaluation Form: Create and Edit

[r-bartlett-gsa]

User Story

As a challenge manager, in order to provide evaluators a form that they can use for scoring submissions, I would like to be able to create new, view or edit already created evaluation forms.

Acceptance criteria:

• A challenge manager can create an evaluation form from the evaluation forms list view, and the user is taken to an evaluation form creation page
  • An Evaluation Form Creation Page allows the user to setup a new evaluation form in a step-by-step process
    • Enter form information
      • Form title
      • Assign the form to a challenge and a challenge phase, Evaluation Form: Challenge Assignment #65
      • Form instructions
  • Enter evaluation criteria details, Evaluation Form: Evaluation Criteria #67, Evaluation Form: Scale Type #69, Evaluation Form: Scoring Type and Options #68
  • Setup evaluation period dates
    • Evaluation start date is the end date of the challenge the evaluation form is assigned to
      • Evaluation start date makes a valid form available to the evaluators
    • Evaluation end date is editable by the challenge manager at any time, even during evaluation period
      • End date disables the form from being used by evaluators
    • The dates activate at midnight EST
  • A challenge manager can save the form:
    • All required fields must be provided
    • The form must be assigned to a challenge / challenge phase that is not closed
    • The form must have at least one evaluation criteria
    • The form is not saved if it does not pass required field validation
  • When a valid form is saved a confirmation is displayed with an option that links to the list of evaluation forms
  • The form fields are editable by the challenge managers until Challenge/Phase end_date
    • Evaluation form end date can be edited any time, even after Challenge/Phase end_date
• In-line validation messages are displayed in addition to error messages that appear at the top of the form (per USWDS guidance)
• A challenge manager can edit an evaluation form from the evaluation forms list view
  • Editing a draft form opens a previously saved form draft and allows the user to continue manipulating form information and fields as outlined above

Development tasks:

• Create EvaluationCriteria model & migration #159
• Build UI - Eval Form Step 1 & 3 - Evaluation Information #160
• Build UI - Eval Form Step 2 - Evaluation Criteria Header #161
• Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria #162
• Build UI - Eval Form Step 2 - Evaluation Criteria Binary Scale #164
• Build UI - Eval Form Step 2 - Evaluation Criteria Rating Scale #165
• Eval Form - Save button implementation #167

Definition of Done

Doing (dev team)

• Code complete
• Code is organized appropriately
• Any known trade offs are documented in the associated GH issue
• Code is documented, modules, shared functions, etc.
• Automated testing has been added or updated in response to changes in this PR
• The feature is smoke tested to confirm it meets requirements
• Database changes have been peer reviewed for index changes and performance bottlenecks
• PR that changes or adds UI
  • include a screenshot of the WAVE report for the altered pages
  • Confirm changes were validated for mobile responsiveness
• PR approved / Peer reviewed
• Security scans passed
• Automate accessibility tests passed
• Build process and deployment is automated and repeatable
• Feature toggles if appropriate
• Deploy to staging
• Move card to testing column in the board

---

Staging

• Usability testing: mobile and desktop (Tracy or Marni)
• Accessibility tested (Marni)
  • Keyboard navigation
  • Focus confirmed
  • Color contrast compliance
  • Screen reader testing
• Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
  • Windows/Chrome
  • Windows/Edge
  • Mac/Chrome
  • Mac/Safari
  • iOS/Safari
• AC review (Renata)
• Deploy to production (production-like environment for eval capability) (dev team)
• Move to production column in the board

---

Production

• User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
• PO / PM approved (Jarah or Renata)
• AC is met and it works as expected (Jarah or Renata)
• Move to done column in the board (Jarah or Renata)

[r-bartlett-gsa]

[r-bartlett-gsa]

Confirmation view:

[stepchud]

This seems like 3 different stories that can be built separately

[r-bartlett-gsa]

This seems like 3 different stories that can be built separately

@stepchud I'm happy to split this into three, but the way I was looking at it, is that the meat of the work is in "Create", the "Edit" is the same as create with some of the fields prefilled, and "View" is the same as edit with fields prefilled and the user cannot edit any of the fields.

[r-bartlett-gsa]

@stepchud Below is the feedback from my review. Some of that feedback can be addressed with other items that are currently in PR review, as it relates to the acceptance criteria from those user stories as well. And the design/styling feedback can be postponed until later, even though I mention it here, but I will add it to the #222

• Add asterisk for all required fields. Currently asterisk is missing for title, challenge, instructions, and end date

• None of Scale Type options should be selected by default, moved to Evaluation Form: Scale Type #69

• When another criteria is added auto-collapse the previous criteria, moved to Evaluation Form: Evaluation Criteria #67

• Form validation error message is not displayed for missing form fields if any of the criteria fields are missing/incorrect, moved to Evaluation Form Validation - Part 1 #181

• Inline error notifications are not shown for criteria fields (the message is not the same as for the other fields and it disappears after clicking anywhere on the screen), moved to Evaluation Form Validation - Part 1 #181

• Cancelation modal is not displayed, moved to Evaluation Form Validation - Part 1 #181

Design/styling feedback added to #222

• Update radio button color
• Update criteria accordion color
• Update "Add Another Criteria" button color
• Step 3 vertical bar is missing
• Criteria points/weight field default text is too large and is not fully visible, perhaps should not have a default text at all
• Restyle "Remove criteria" and "Add another criteria" buttons
• Form validation error message is styled incorrectly
• Revisit all form field titles and subtitles

Also, please review the definition of done checklist.

[mhotch24]

@TCKapGrp @r-bartlett-gsa A11y and Cross Browser testing complete and passed.

[r-bartlett-gsa]

@stepchud One small update is needed for this story:

• Add asterisk for all required fields. Currently asterisk is missing for title, challenge, instructions and end date