Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[162] Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria #219

Merged
merged 31 commits into from
Nov 1, 2024
Merged

[162] Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria #219

merged 31 commits into from
Nov 1, 2024

Conversation

cpreisinger
Copy link
Contributor

@cpreisinger cpreisinger commented Oct 18, 2024 •
edited
Loading

@cpreisinger cpreisinger self-assigned this Oct 18, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 10/22/24 milestone Oct 18, 2024
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_platform into 162/eval…
13c836e 
…-form-evaluation-criteria

* 'dev' of github.com:GSA/Challenge_platform: (36 commits)
  WAVE and codeclimate
  add default combo-box phase for edits
  add a reusable helper function for challenge_phase_title
  turn off secure cookies for non-production envs
  Revert env var name
  title maxlength
  rubocop
  disallow nil values from being passed by the evaluation form params sanitizer
  use random email for mock user generation
  mostly working phase association
  add default end date for test challenges
  56 fix logout sticking issue, tld_length, etc
  parse the mm/dd/yyyy dates from the date-picker
  set min date attribute on datepicker when challenge phase is selected
  persist end date
  use phase end date to populate eval form start date
  render all phases of multiphase challenge in combo box
  fix mislabelled uuid
  remove hello world stiumulus controller
  add class name to has many
  ...
@cpreisinger
164 Add support for binary scale to eval criteria
9ade174
@r-bartlett-gsa r-bartlett-gsa linked an issue Oct 22, 2024 that may be closed by this pull request
Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria #162
Closed
13 tasks
stepchud
stepchud reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few specs failing

app/javascript/evaluation_criteria.js Outdated Show resolved Hide resolved
db/migrate/20241017172408_remove_unique_title_index_from_evaluation_criteria.rb Show resolved Hide resolved
@cpreisinger
61 Accordion titles and collapse validity check
2af7b30
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_platform into 162/eval…
e55b445 
…-form-evaluation-criteria

* 'dev' of github.com:GSA/Challenge_platform: (33 commits)
  Fix broken migration staging (#235)
  fix the migrations on challenge-dev (#234)
  [104] Evaluation Form View (#225)
  [52] Dashboard fixup (#229)
  Bump axe-core-rspec from 4.10.0 to 4.10.1 (#220)
  [197] Manage Submissions Index (#216)
  remove extra comments from db/structure.sql
  add an optional rbenv hook for local dev
  remove APP_DOMAIN for local env
  [Snyk] Security upgrade rails from 7.2.1 to 7.2.1.1 (#217)
  Bump propshaft from 0.9.1 to 1.1.0
  Bump rubocop-rspec from 3.0.5 to 3.1.0
  Update Gemfile.lock
  fix: Gemfile & Gemfile.lock to reduce vulnerabilities
  remove ruby-lsp no longer needed
  Bump ruby-lsp from 0.18.4 to 0.20.1
  add CC_TEST_REPORTER_ID for CCI
  fix javascript error on combo box
  Update app/models/submission.rb
  199 Allow unique custom URLs for specs
  ...
@cpreisinger cpreisinger force-pushed the 162/eval-form-evaluation-criteria branch from 873875b to e55b445 Compare October 28, 2024 03:00
@cpreisinger cpreisinger changed the title [162] Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria [#162] Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria Oct 28, 2024
@cpreisinger cpreisinger changed the title [#162] Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria [162] Build UI - Eval Form Step 2 - Evaluation Criteria Add/Remove Criteria Oct 28, 2024
cpreisinger and others added 6 commits October 28, 2024 08:46
@cpreisinger
Merge branch '165/evaluation-criteria-rating-scale' into 162/eval-for…
ef80db5 
…m-evaluation-criteria

* 165/evaluation-criteria-rating-scale:
  61 Accordion titles and collapse validity check
  165 Fix bug with rating options on new criteria
  165 Option label bug with form validation error
  165 Fix bug with new criteria option labels
  165 Add support for rating scale to eval criteria
  164 Add support for binary scale to eval criteria
@cpreisinger
61 Fix rspec failure with criteria option labels
c23e016
@cpreisinger
162 Initial eval criteria stimulus port
eea695f
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_platform into 162/eval…
85725f6 
…-form-evaluation-criteria

* 'dev' of github.com:GSA/Challenge_platform:
  [205] Evaluator Submission Assignments (#233)
  fail cloud_start.sh script on any errors (#238)
@stepchud
update yarn.lock
db83008
@cpreisinger
61 Update dependency versions
3394377
stepchud
stepchud reviewed Oct 30, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
stepchud and others added 2 commits October 30, 2024 09:52
stepchud
stepchud reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged, just left a few cleanup comments. The functionality is working afaict. Code structure is clean and readable. 🙌

app/assets/stylesheets/application.sass.scss Outdated Show resolved Hide resolved
app/javascript/controllers/evaluation_criteria_controller.js Show resolved Hide resolved
app/javascript/controllers/evaluation_criteria_controller.js Outdated Show resolved Hide resolved
app/javascript/controllers/evaluation_criteria_controller.js Outdated Show resolved Hide resolved
app/javascript/controllers/evaluation_criteria_controller.js Outdated Show resolved Hide resolved
app/views/evaluation_forms/_evaluation_criterion_fields.html.erb Show resolved Hide resolved
db/structure.sql Outdated Show resolved Hide resolved
spec/factories/evaluation_criteria.rb Show resolved Hide resolved
@cpreisinger
61 Remove unsued targets and code readability
ac91b8e
@cpreisinger
Merge branch '162/eval-form-evaluation-criteria' of github.com:GSA/Ch…
6e2e07a 
…allenge_platform into 162/eval-form-evaluation-criteria

* '162/eval-form-evaluation-criteria' of github.com:GSA/Challenge_platform:
  revert structure.sql
  Update .circleci/config.yml
  Bump turbo-rails from 2.0.10 to 2.0.11 (#242)
  Bump rails from 7.2.1.1 to 7.2.1.2 (#241)
  Bump pg from 1.5.8 to 1.5.9 (#240)
  Bump rubocop from 1.66.1 to 1.67.0 (#239)
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_platform into 162/eval…
cfeb931 
…-form-evaluation-criteria

* 'dev' of github.com:GSA/Challenge_platform:
  Adds dev/test account login page (#244)
@cpreisinger
61 Add the confirmation screen for eval form save
2d05253
stepchud
stepchud approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@stepchud stepchud merged commit c66bcaf into dev Nov 1, 2024
11 checks passed
@stepchud stepchud deleted the 162/eval-form-evaluation-criteria branch November 1, 2024 17:00
This was linked to issues Nov 1, 2024
Build UI - Eval Form Step 2 - Evaluation Criteria Binary Scale #164
Closed
Build UI - Eval Form Step 2 - Evaluation Criteria Rating Scale #165
Closed
This was referenced Nov 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees

@cpreisinger cpreisinger

Labels
None yet
Projects
None yet
Milestone
Sprint 11/05/24
3 participants
@cpreisinger @stepchud @r-bartlett-gsa