Add [ QA | ARCHIVER | REPORT ] #546
Conversation
- No need for python2-secrets - No need to pin pysaml2 (also it's included in saml2auth setup.py... so pip should be happy https://github.com/keitaroinc/ckanext-saml2auth/blob/main/setup.py#L82 - Add in dependencies for qa/report/archiver
nickumia-reisys
changed the title
db_init never had an error before so this was not a problem, but the type of e.output is bytes which can't be compared to a string, so I'm overwriting for type matching
redis was spelled wrong and ckan might need the celery ini config
well, for the secure version :/
There was a problem hiding this comment.
Looks good, and could be merged as is. Thanks @nickumia-reisys !
| -e git+https://github.com/gsa/ckanext-qa.git@datagov#egg=ckanext-qa | ||
| -e git+https://github.com/ckan/ckanext-archiver.git@master#egg=ckanext-archiver | ||
| -e git+https://github.com/ckan/ckanext-report.git@master#egg=ckanext-report |
There was a problem hiding this comment.
Just to make sure, do these need to be installed in editable mode? Did we try without? Either way, could we make a comment (either not tested, or with a note about errors when installing without -e?
There was a problem hiding this comment.
If it's not in editable mode, the custom templates are missing and can't be accessed. So yeah, we need it in editable mode. Also, the cli commands don't work if not editable.
(I did try it without editable initially)
| # GSA FIX: e.output is bytes upstream | ||
| if "OperationalError" in str(e.output): |
There was a problem hiding this comment.
Can we push this fix upstream?
There was a problem hiding this comment.
I'm not sure. I think this is a PY2 vs PY3 issue that upstream is still allowing support for PY2 😕
Related to