Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (some) Harvesting Hard Failures #599

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix (some) Harvesting Hard Failures #599

merged 2 commits into from
Oct 20, 2022

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys marked this pull request as ready for review October 19, 2022 20:55
@nickumia-reisys nickumia-reisys requested a review from a team October 19, 2022 21:28
@FuhuXia
Copy link
Member

FuhuXia commented Oct 19, 2022 •
edited
Loading

Let me validate the fix on development space. I mean creating a harvest source with known issue and checking the report before and after the fix.

[update]
Hard to match fix to error messages. Did not validate on development. We can merge it.

@robert-bryson robert-bryson merged commit c325ebf into main Oct 20, 2022
@robert-bryson robert-bryson deleted the fix-hard-fail-harvesting branch October 20, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FuhuXia FuhuXia FuhuXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickumia-reisys @FuhuXia @robert-bryson