Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Automated Snyk PRs 🥽 #677

Merged
merged 24 commits into from
Dec 8, 2022
Merged

Fix Automated Snyk PRs 🥽 #677

merged 24 commits into from
Dec 8, 2022

Conversation

@nickumia-reisys nickumia-reisys marked this pull request as ready for review December 8, 2022 14:42
@nickumia-reisys nickumia-reisys requested a review from a team December 8, 2022 14:42
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry in general that this custom solution (while well thought out and detailed) will eventually break due to things outside our control (like pip changes), but for now this is great!

@nickumia-reisys nickumia-reisys merged commit 6901cfc into main Dec 8, 2022
@nickumia-reisys nickumia-reisys deleted the fix-snyk-prs branch December 8, 2022 15:52
@nickumia-reisys
Copy link
Contributor Author

I worry in general that this custom solution (while well thought out and detailed) will eventually break due to things outside our control (like pip changes), but for now this is great!

That's the worry we carry as developers in the ever-changing world of technology. But yes, we carry some burden of maintaining this. I see this as part of our deployment pipeline which would always be a custom solution in any case.

nickumia-reisys added a commit to GSA/inventory-app that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants