-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cypress test #149
Add cypress test #149
Conversation
For error in linting ValueError: Error code '#' supplied to 'ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$' https://stackoverflow.com/questions/74558565/flake8-error-code-supplied-to-ignore-option-does-not-match-a-z1-30
…agovtheme into add-cypress-test
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.8.15-final-0 -----------
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good! I would like to somehow normalize ui-test
with test
, as we're definitely doing similar things in 2 very different ways. That can be done in a follow up however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌴
Pull Request
related to GSA/data.gov#3521
About
Add Cypress tests (or other UI tests) implemented in datagovtheme.
PR TASKS
The actual code changes.