Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress test #149

Merged
merged 10 commits into from
Nov 29, 2022
Merged

Add cypress test #149

merged 10 commits into from
Nov 29, 2022

Conversation

Jin-Sun-tts
Copy link
Contributor

Pull Request

related to GSA/data.gov#3521

About

Add Cypress tests (or other UI tests) implemented in datagovtheme.

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Added new directory e2e for Cypress tests
  • Bumped version number in setup.py (also checked on PyPi).

@github-actions
Copy link

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.15-final-0 -----------

Name Stmts Miss Cover
ckanext/datagovtheme/init.py 6 3 50%
ckanext/datagovtheme/blueprint.py 26 11 58%
ckanext/datagovtheme/data/init.py 0 0 100%
ckanext/datagovtheme/data/dynamic_menu/init.py 0 0 100%
ckanext/datagovtheme/helpers.py 344 224 35%
ckanext/datagovtheme/plugin.py 38 11 71%
TOTAL 414 249 40%
Required test coverage of
================== 22 passed, 1147

@Jin-Sun-tts Jin-Sun-tts marked this pull request as ready for review November 28, 2022 15:36
@Jin-Sun-tts Jin-Sun-tts requested a review from a team November 28, 2022 15:37
jbrown-xentity
jbrown-xentity previously approved these changes Nov 28, 2022
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good! I would like to somehow normalize ui-test with test, as we're definitely doing similar things in 2 very different ways. That can be done in a follow up however.

e2e/cypress/fixtures/example.json Outdated Show resolved Hide resolved
e2e/cypress/support/commands.js Outdated Show resolved Hide resolved
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌴

@nickumia-reisys nickumia-reisys merged commit 5aebdd4 into main Nov 29, 2022
@nickumia-reisys nickumia-reisys deleted the add-cypress-test branch November 29, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants