Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical titles are ok #135

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Numerical titles are ok #135

merged 4 commits into from
Jan 30, 2023

Conversation

A title of '707' is okay to have, so even if json doesn't recognize it as a string, convert it after loading
@nickumia-reisys nickumia-reisys marked this pull request as ready for review January 30, 2023 22:49
@nickumia-reisys nickumia-reisys requested a review from a team January 30, 2023 22:50
@robert-bryson
Copy link

What was the type that was causing an issue? Can it/all possible types be cleanly cast into a str?

@nickumia-reisys
Copy link
Author

@robert-bryson The only types we know about are json number and string. The number was the one throwing the issue.

The other possible types are an object (JSON object), array, boolean, and null. But if there are any of those types... I think we have bigger issues from agencies haha...

@nickumia-reisys nickumia-reisys merged commit 010aa45 into main Jan 30, 2023
@nickumia-reisys nickumia-reisys deleted the numerical-titles-are-ok branch January 30, 2023 22:57
nickumia-reisys added a commit to GSA/catalog.data.gov that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants