Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page Title to download and outbound link tables #4992

Closed
6 tasks
tdlowden opened this issue Dec 2, 2024 · 10 comments
Closed
6 tasks

Add Page Title to download and outbound link tables #4992

tdlowden opened this issue Dec 2, 2024 · 10 comments
Assignees
Labels
metrics Stats, metrics and data visualizations of catalog

Comments

@tdlowden
Copy link
Member

tdlowden commented Dec 2, 2024

User Story

In order to understand which datasets link refer to, public users wants to see the name of the page the files are clicked from.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

  • GIVEN a user visits a metrics page for an org
    WHEN the outbound link and download file tables render
    THEN they should include a column for page title

Background

On their own, it is difficult to decipher what a download file link means without clicking it Image

Security Considerations (required)

None

Sketch

  • Add page title into the API calls that populate the outbound and download reports saved into S3
  • Add page URL into the API calls that populate the outbound and download reports saved into S3
  • Add Page Title as a column in the download files table
  • Add Page Title as a column in the outbound link table
  • Link Page Title text to page URL
@tdlowden tdlowden added the metrics Stats, metrics and data visualizations of catalog label Dec 2, 2024
@tdlowden tdlowden moved this to 📥 Queue in data.gov team board Dec 2, 2024
@tdlowden tdlowden removed the status in data.gov team board Dec 2, 2024
@rshewitt rshewitt moved this to 🏗 In Progress [8] in data.gov team board Dec 4, 2024
@rshewitt rshewitt self-assigned this Dec 4, 2024
@rshewitt
Copy link
Contributor

rshewitt commented Dec 5, 2024

@tdlowden is this what you're looking for in the UI?

Image

@rshewitt
Copy link
Contributor

rshewitt commented Dec 6, 2024

@tdlowden ran into an interesting situation with the "Most downloaded dataset files". these results are current so they're gonna be different than what's on prod now.

Image

the same file was downloaded but on different pages. one is the dataset page and the other is the resource page.

@tdlowden
Copy link
Member Author

tdlowden commented Dec 9, 2024

@rshewitt Yep, I'm aware of this. But without a descriptive universal "File Name" we can capture across pages in a single row (in your example, the file name is rows.csv, which is useless), this is the expected outcome. It's the best we can currently do

@rshewitt
Copy link
Contributor

rshewitt commented Dec 9, 2024

i regenerated the reports for november so what's on s3 should be updated with my changes. 11ty pages on main/prod get rebuilt nightly so in the meantime here's the preview pages offers

Screenshot 2024-12-09 at 12 09 30 PM

@tdlowden
Copy link
Member Author

tdlowden commented Dec 9, 2024

2 thoughts @rshewitt

  1. Can you adjust the column header to Page Title instead of just title? I don't want people to think thats the file name.

  2. Is there any way to make the page title column a bit wider, so that it can fit more of the page title in the row before expanding?

@rshewitt
Copy link
Contributor

rshewitt commented Dec 9, 2024

2 thoughts @rshewitt

  1. Can you adjust the column header to Page Title instead of just title? I don't want people to think thats the file name.
  2. Is there any way to make the page title column a bit wider, so that it can fit more of the page title in the row before expanding?
  1. yeah sure
  2. yeah i'll look into it

@rshewitt
Copy link
Contributor

rshewitt commented Dec 9, 2024

i also noticed something odd about the outbound links. i'll look into it.

@tdlowden
Copy link
Member Author

tdlowden commented Dec 9, 2024

@rshewitt what did you find with outbound?

@rshewitt rshewitt moved this from 👀 Needs Review [2] to 🏗 In Progress [8] in data.gov team board Dec 9, 2024
@Bagesary
Copy link

pairing and PR review in progress

@rshewitt rshewitt moved this from 🏗 In Progress [8] to 👀 Needs Review [2] in data.gov team board Dec 11, 2024
@rshewitt
Copy link
Contributor

  • global and per-org are complete: https://data.gov/metrics/
  • the download and outbounds table columns vary in width because of the underlying class used. would require some work to get the first and second rows fixed and align with each other.

@rshewitt rshewitt moved this from 👀 Needs Review [2] to ✔ Done in data.gov team board Dec 12, 2024
@rshewitt rshewitt closed this as completed by moving to ✔ Done in data.gov team board Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Stats, metrics and data visualizations of catalog
Projects
Status: ✔ Done
Development

No branches or pull requests

3 participants