[catalog][inventory] fix NR reporting #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mentioning the original ticket. Leaving this so we'll update the original ticket status to reflect that we don't want to report on staging statistics. |
adborden
force-pushed
the
feature/app-env
branch
from
0f16fc3 to
6facb2a
Compare
Specify CKAN application environment variables from ansible configuration instead of template.
Move NR env variables out to Ansible configuration instead of template. Now catalog/inventory don't need to know anything about New Relic.
Missing some variables, make sure to set this for all environments.
Make sure to enable New Relic in production and staging. Set a default in case it's unset.
adborden
force-pushed
the
feature/app-env
branch
from
6facb2a to
4b98ed2
Compare
jbrown-xentity
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where staging and sandbox instances are reporting to the
production APM app.
This updates the New Relic configration for APM in a consistent way so that
environment is a separate app (or falls into the "unknown" bucket).
The New Relic variables are removed from the catalog and inventory roles and
specified through the dot env file. This way the roles don't need to know about
the details of New Relic, there's a standard interface (environment variables)
to configure NR.