This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Update README.md #221
Open
Update README.md #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for digging into this. Can you double check the npm commands in package.json? I almost feel like the docs should just be |
|
The package.json scripts only seem to manage the Jekyll build the PR is about recreating the steps to run the hypergrc container to edit the contents in ‘_data/OpenControl’ |
adborden
reviewed
Jan 29, 2020
| $ docker image build --tag hypergrc:latest . | ||
| $ cd .. | ||
| $ export REPOSITORY=`pwd` | ||
| $ docker container run -v $REPOSITORY:/opencontrol -p 127.0.0.1:8000:8000 --rm -it hypergrc:latest |
There was a problem hiding this comment.
I think this can be simplified to:
$ npm install
$ npm run edit-controls
The npm postinstall script runs install-edit-controls which does the repo clone and docker build. postinstall is run automatically from npm install. npm run edit-controls then runs the edit-controls script which starts the docker container, so that should be it!
kimwdavidson
requested review from
adborden
and removed request for
adborden
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @adborden @mogul just tried to run it and had to make these corrections