Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cud ckan #20

Merged
merged 17 commits into from
Sep 26, 2023
Merged

Cud ckan #20

merged 17 commits into from
Sep 26, 2023

Conversation

rshewitt
Copy link
Contributor

Pull Request

Related to 4463, 4464, 4465.

About

CKAN package/dataset creation, deletion, update, and patching is included in the compare branch. In addition, dcatus-to-ckan conversion functions are also included.

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in pyproject.toml (also checked on PyPi).

@rshewitt rshewitt requested a review from a team September 26, 2023 19:31
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
harvester
   __init__.py30100% 
harvester/db/models
   __init__.py50100% 
   models.py530100% 
harvester/extract
   __init__.py1922 89%
   dcatus.py1122 82%
harvester/load
   __init__.py00100% 
   ckan.py800100% 
harvester/utils
   __init__.py00100% 
   json.py2277 68%
   pg.py3544 89%
   s3.py2466 75%
harvester/validate
   __init__.py00100% 
   dcat_us.py240100% 
TOTAL2762192% 

Tests Skipped Failures Errors Time
33 0 💤 0 ❌ 0 🔥 25.235s ⏱️

Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rshewitt rshewitt merged commit 8c76fd9 into main Sep 26, 2023
4 checks passed
@rshewitt rshewitt deleted the cud_ckan branch September 26, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants