Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable NR Reporting (minimal) #39

Closed
wants to merge 9 commits into from
Closed

Stable NR Reporting (minimal) #39

wants to merge 9 commits into from

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented May 1, 2022 •
edited
Loading

Built on top of #37, Relates to GSA/data.gov#3062

New Additions:

  • Parameterize NR Log URI

Deprecations/Needs Work:

  • S3 Output doesn't work properly, so it's commented out.

@nickumia-reisys nickumia-reisys mentioned this pull request May 1, 2022
Closed
4 tasks
mogul
mogul suggested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good generally, but I don't want to approve it until S3 is working since we were actively shipping logs to GSA's SOC that way.

This was referenced May 2, 2022
Merged
Closed
@nickumia-reisys
Copy link
Contributor Author

Superseded by #40 which makes NR and S3 work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogul mogul mogul requested changes

@jbrown-xentity jbrown-xentity jbrown-xentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickumia-reisys @mogul @jbrown-xentity