Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGITAL-30: Migrate node templates #37

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Nov 8, 2024

Jira ticket

DIGITAL-30

Purpose

Migrate Hugo templates for events, authors, news, events, community, and topic nodes to match preexisting HTML DOM.
Converted partials to functional twig templates
Mark and add placeholders to indicate partials that perform a query and are not yet migrated.

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

drush cr to detect theme suggestions and preprocess hooks

QA/Testing instructions

News, events, authors, topics, community nodes use the new templates.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@omerida omerida force-pushed the feature/DIGITAL-30-node-templates branch 3 times, most recently from 4cb4538 to 03a0184 Compare November 8, 2024 18:41
@omerida omerida requested a review from mattsqd November 8, 2024 18:41
@omerida omerida force-pushed the feature/DIGITAL-30-node-templates branch 3 times, most recently from d98cc90 to fe0d6a2 Compare November 14, 2024 20:31
- Adds template for news, authors and related field templates.
- Move authors markup to re-usable partial that other templates can call.
- Add community page template
- Adds event template
- Adds stage templates for events and share tools template
- Adds stub for topics content type
- Show summary and legislation card on topic page.

- Add archived content warning to news page.
- Add created date to news meta div
- Add page header to news and events pages.
- Add breadcrumb to event and news nodes
- Add breadcrumb and header to community template.
- Tagging not-migrated sections in topics template
- Tagging not-migrated sections in communities template
 - Add resources and basic page templates.
 - Add authors template
 - Add Guide templates.
 - Add landing page type field to use for templates suggestions.
 - Migrate event-specific landing page template
 - Migrate community landing page
 - Migrate resources landing page
 - Migrate guide landing page
 - Migrate job board landing page
 - Migrate news landing page
@omerida omerida force-pushed the feature/DIGITAL-30-node-templates branch from 7e38fe5 to d41ee1c Compare November 19, 2024 20:28
Export deck field for landing pages
@omerida omerida force-pushed the feature/DIGITAL-30-node-templates branch from d41ee1c to 4c0568b Compare November 19, 2024 20:30
@mattsqd mattsqd merged commit 559e1d9 into develop Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants