Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue_template.yml #2293

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Update issue_template.yml #2293

merged 3 commits into from
Jan 30, 2025

Conversation

sheevdave
Copy link
Contributor

added "This includes items related to accessibility." to 3 sections

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

Please enter a detailed description here.

TODO (optional)

  • TODO item 1
  • TODO item 2
  • TODO item ...

Security Considerations

  • Consideration 1
  • Consideration 2
  • Consideration ...

A11y Checks (if applicable)

added "This includes items related to accessibility." to 3 sections
Copy link
Contributor Author

@sheevdave sheevdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added accessibility section

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sheevdave! 🎉

The changes all look good, there's just one small tweak to make with the id property to make sure the form works properly. 🙂

.github/ISSUE_TEMPLATE/issue_template.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @sheevdave!

@ccostino ccostino merged commit 653f3f5 into main Jan 30, 2025
11 checks passed
@ccostino ccostino deleted the sheevdave-patch-3 branch January 30, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants