Remote input: Synchronize _ensureAdapter #1925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dapter();' in input.js. fix GSConnect#1836
So that we don't miss the first input event whenever a new session needs to be started, have `_ensureAdapter` return the session object it creates. Resolve the implicit Promise for that object in its callers, using `.then()`. Fixes GSConnect#1836
andyholmes
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #1922 by @Plrrb,
So that we don't miss the first input event whenever a new session needs to be started, have
_ensureAdapterreturn the session object it creates. Resolve the implicit Promise for that object in its callers, using.then().Fixes #1836