Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff interface throughput via transvector #456

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

claimg
Copy link

@claimg claimg commented Feb 8, 2024

Instant transport from interface -> transvector -> interface. See attachments and code for more info.

89379c0d-80f1-4594-8806-50065f0f28e1.mp4

@Dream-Master Dream-Master requested review from MCTBL, Laiff, a team and repo-alt February 8, 2024 20:39
@BlueWeabo
Copy link
Member

Does this change make ThaumicTinkerer a dependency required at runtime with only ae2 installed? And if it does, could you make sure its not? (Personally always forget if having an import breaks something or not, know it will always be required at compile time for no error)

@miozune
Copy link
Member

miozune commented Feb 10, 2024

Import doesn't affect anything on runtime, but without mod load check it results in crash trying to load non-existing class. I also think dependency on TC and CC are not necessary if you remove transitive = false from TT dep.

@Dream-Master Dream-Master merged commit bbbf70a into GTNewHorizons:master Feb 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants