Ring of Loki Block Selection Work

[LewisSaber]

• Added new keybind, when pressed removes selection from all blocks
• Made it so if ring of loki is off selection is not drawn

[combusterf]

Just a few cleanups to do, looking fine otherwise.

[combusterf]

Code style aside, at this rate we seem to bind the entire keyboard to the loki ring. From an user interaction perspective this is rather poor design - it requires you to deconflict keybinds, learn from the settings menu what the features are, and that you move your hand varying distances across the keyboard.

Wouldn't it be better to limit keybinds to at most one key, and combine it with shift/ctrl/mouse instead?

[LewisSaber]

Thats a fair point, I have run out of ideas I can implement, if I think of any and it requires new hotkey, I will try to combine some of them(like turning on/off both mode and breaking)

[Alastors]

Code style aside, at this rate we seem to bind the entire keyboard to the loki ring. From an user interaction perspective this is rather poor design - it requires you to deconflict keybinds, learn from the settings menu what the features are, and that you move your hand varying distances across the keyboard.

Wouldn't it be better to limit keybinds to at most one key, and combine it with shift/ctrl/mouse instead?

That, or at this point it might necessitate keybind wheels, like how TC handles foci

[combusterf]

Code is a-ok now. Feel free to merge once we have consensus on the keybind topic.

Changes addressed

[combusterf]

My gut feeling says the focus wheel would be a bit overengineered, and shift/ctrl combinations would be fine enough as far as I'm concerned. There's an inherent risk in merging the feature as-is now to never improve it later, so you can address it and I'll get it merged, or if a second opinion comes to approve it.

(and sorry for the spam, it took some trial and error to remove myself as a blocker)

[Alastors]

My gut feeling says the focus wheel would be a bit overengineered, and shift/ctrl combinations would be fine enough as far as I'm concerned. There's an inherent risk in merging the feature as-is now to never improve it later, so you can address it and I'll get it merged, or if a second opinion comes to approve it.

(and sorry for the spam, it took some trial and error to remove myself as a blocker)

That's probably fair, would just be future proofing the ring incase people want to add more features, but yeah thats a fair point

[LewisSaber]

Huge thanks to themightyjevry and Staffix for helping me make tooltip

[combusterf]

I like this way better, just a few cleanups from the new changes and I'll have it merged

[LewisSaber]

This should be it