This fixes Botania creative tab breaking and shouldn't affect the ring itself #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneEyeMaker
requested changes
Oct 28, 2023
src/main/java/vazkii/botania/common/item/relic/ItemLokiRing.java
Outdated
Show resolved
Hide resolved
…nside of isRingEnabled and isRingBreaking methods.
OneEyeMaker
approved these changes
Oct 28, 2023
DrParadox7
pushed a commit
to DrParadox7/Botania
that referenced
this pull request
Jun 1, 2024
…g itself (GTNewHorizons#34) * This fixes creative tab breaking and shouldn't affect the ring itself * Adding change suggest by OneEyeMaker, placed check for tag compound inside of isRingEnabled and isRingBreaking methods. * Forgot that bit. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should fix the creative tab crashing your game without affecting the ring itself.