Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various changes #61

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

shadoxxhd
Copy link

  • enchanted soil affects passive generating flowers and Loonium speed, and can be silk touched
  • Gourmaryllis now generates mana continously (total amount unchanged)
  • Gourmaryllis uses the higher of hunger and saturation of the given food
  • Gourmaryllis can consume stacks of items to run for longer at a time, and doesn't consume other items while "eating"
  • Pixie ring now provides a pixie chance similar to a single piece of elementium armor (though obviously no armor value)

I'll PR my Loonium blacklist changes if and when I get around to actually linking it to the config file.

- enchanted soil affects passive generating flowers and Loonium speed, and can be silk touched
- Gourmaryllis now generates mana continously (total unchanged)
- Gourmaryllis uses the higher of hunger and saturation of the given food
- Gourmaryllis can consume stacks of items to run for longer at a time, and doesn't consume other items while "eating"
- Pixie ring now provides a pixie chance similar to a single piece of elementium armor (though obviously no armor value)
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gourmaryllis can consume stacks of items to run for longer at a time, and doesn't consume other items while "eating"

thats a big no.

The other changes are weird too though.

@chochem chochem added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Oct 16, 2024
@EnderProyects
Copy link

If Loonium is now faster, I think is the time to add it to World Accelerator blacklist...

@shadoxxhd
Copy link
Author

The only change to Loonium was to double its mana buffer, so overgrowth seeds correctly cause it to do 2 operations per cycle (at double the mana cost). Are Looniums more expensive to make than finding overgrowth seeds in GTNH? Otherwise, it has no balance implications.

The Gourmaryllis pickup change was mostly to prevent it from "griefing" when eg. mining a chest of food near it. The other changes were mostly aesthetics/preference without strong reasons.

Pixie ring just seemed very weak compared to other Botania rings.

All of these changes were just personal preference; I just figured some of these tweaks might be of interest.

@Dream-Master Dream-Master removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 8, 2024
@Dream-Master Dream-Master requested a review from a team December 21, 2024 16:18
@combusterf
Copy link
Collaborator

I agree with chochem, removal of challenge mechanics is a no-go. The rest of the changes seem quite arbitrary and don't sound well thought through.

It would definitely have been more correct to request each change separately.

@serenibyss serenibyss marked this pull request as draft December 29, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants