Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essentia Condenser Nuke #1 #26

Closed
wants to merge 1 commit into from
Closed

Essentia Condenser Nuke #1 #26

wants to merge 1 commit into from

Conversation

Alastors
Copy link

@Alastors Alastors commented Dec 13, 2023

As promised, the second something that could feasibly replace the condenser gets introduced, I'd nuke the condenser, here that is.

I'm going to leave the condenser itself in-tact as a block in-case someone actually wants to fix it in the future (this just removes the recipe, coremod PR inbound)

Sister PR to:
GTNewHorizons/MagicBees#34
and
GTNewHorizons/NewHorizonsCoreMod#779

Fixes:
GTNewHorizons/GT-New-Horizons-Modpack#10522

As promised, the second something that could feasibly replace the condenser gets introduced, I'd nuke the condenser, here that is.

I'm going to leave the condenser itself in-tact as a block in-case someone actually wants to fix it in the future (this just removes the recipe, coremod PR inbound)
Alastors added a commit to GTNewHorizons/NewHorizonsCoreMod that referenced this pull request Dec 13, 2023
As promised, the second something that could feasibly replace the condenser gets introduced, I'd nuke the condenser, here that is.

I'm going to leave the condenser itself in-tact as a block in-case someone actually wants to fix it in the future (this just removes the recipe replacements from coremod, base recipes were handled as well)

Sister PR to:
GTNewHorizons/MagicBees#34
and
GTNewHorizons/Gadomancy#26
@Dream-Master Dream-Master requested a review from a team December 13, 2023 06:47
@Dream-Master Dream-Master added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 13, 2023
@@ -100,6 +100,7 @@ gadomancy.research_page.ESSENTIA_COMPRESSOR.4=By assembling a reinforced shell a
gadomancy.research_page.ESSENTIA_COMPRESSOR.6=Due to the incredible amount of energy in the core of the Essentia Condenser, it cannot safely interact with pipes, nor can essentia be directly placed into the device by hand. Golems have to be used to insert the first bit of essentia into the condenser for it to start accepting on its own. Once essentia is stored however, the Condenser will actively pull in essentia from every available jar, reservoir, and mirror within 5 blocks of he device, however it only seems to pull from containers that have less essentia inside them than the main condenser. Although direct physical interaction with the Essentia Condenser is limited to golems, infusion altars as well any device that can pull from an essentia mirror can supply themselves.
gadomancy.research_page.ESSENTIA_COMPRESSOR.8=The Essentia Condenser, like most things that contain large amounts of liquid essentia, does not deal with large amounts of physical stress very well. If any of the blocks in the structure are broken while any essentia is contained inside, the entire device will violently explode, leaving a large amount of flux and taint behind. Unlike its slightly more tame counterpart, the essentia reservoir, if the Essentia Condenser has any essentia within, it will release enough destabilized flux to immediately taint the land.
gadomancy.research_page.ESSENTIA_COMPRESSOR.9=If an element of darkness is placed on an ancient pedestal near the condenser, the core of the condenser will consume it, allowing the condenser to increase its internal capacity by a reasonable amount. The highest point the capacity of the condenser can be pushed to with this method is 3000 per aspect.<LINE>You noticed while standing near the structure, that the pull of the Element of Darkness in the Condensers core is enough to gradually pull you closer. Could it be getting bigger? You don’t think so...hopefully...
gadomancy.research_page.ESSENTIA_COMPRESSOR.4=No Recipe, sorry. Try the Apiamancer's Drainer.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gadomancy.research_page.ESSENTIA_COMPRESSOR.4=No Recipe, sorry. Try the Apiamancer's Drainer.
gadomancy.research_page.ESSENTIA_COMPRESSOR.5=No Recipe, sorry. Try the Apiamancer's Drainer.

@EnderProyects
Copy link

If you remove the essentia condenser, you should change the creative essentia cell ( maybe use the new 16384k cells they where added)

@Dream-Master
Copy link
Member

@Alastors is the new magic bees block a replacement of this one ?

@EnderProyects
Copy link

Also @Alastors could just be removed the formation of the multiblock ( is in the first lines of the recipes code if I remember correctly) , so that the blocks can still be crafted and used in the creative essentia recipe

@Alastors
Copy link
Author

@Alastors is the new magic bees block a replacement of this one ?

Not directly, it’s a replacement in spirit, but the condenser was a glitch that held up another glitch, this is a balanced bandaid. It’s not perfect, but frankly it’s enough to justify nuking the original glitch.

@Alastors Alastors closed this Dec 13, 2023
@Alastors Alastors reopened this Dec 13, 2023
@Dream-Master Dream-Master marked this pull request as draft December 14, 2023 10:34
@Dream-Master
Copy link
Member

@Alastors i set it draft

@Dream-Master Dream-Master removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 18, 2023
@Dream-Master
Copy link
Member

not needed anymore

@Dream-Master Dream-Master deleted the condenser-nuke branch December 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants