Small Cleanup (mostly @Share / @Local)
#276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchej123
approved these changes
Nov 7, 2023
| @@ -18,13 +18,13 @@ | |||
| @Mixin(ModuleHarvestCraft.class) | |||
| public class MixinHungerOverhaulModuleHarvestCraft { | |||
|
|
|||
| private static final Map<Item, FoodValues> foodValuesMap = new HashMap<Item, FoodValues>() { | |||
There was a problem hiding this comment.
Not that I mind, but what's the objection to the anonymous inner class?
There was a problem hiding this comment.
double braces initializer is a famous antipattern. it creates a one time class that boost the memory usage, slow down class loading, confuse junior developers and make certain static analysis tool very unhappy.
|
damn we love sugar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit history.