Fix EffectRenderer keeping reference to world instance when leaving world #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexdoru
requested changes
Nov 13, 2023
...ava/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinMinecraft_ClearEffectRenderer.java
Outdated
Show resolved
Hide resolved
...ava/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinMinecraft_ClearEffectRenderer.java
Outdated
Show resolved
Hide resolved
|
This method says to call it with null to clean, why not do it as well, could that be a leak too
|
tth05
force-pushed
the
effect-renderer-world-leak
branch
2 times, most recently
from
a820b27 to
0db41c7
Compare
Good idea. I think RenderGlobal leaks as well |
|
I also added another fix for RenderGlobal |
Alexdoru
reviewed
Nov 14, 2023
tth05
force-pushed
the
effect-renderer-world-leak
branch
from
5c756ef to
30d5d2b
Compare
Alexdoru
requested changes
Nov 14, 2023
...com/mitchej123/hodgepodge/mixins/early/minecraft/MixinMinecraft_ClearRenderersWorldLeak.java
Outdated
Show resolved
Hide resolved
...ain/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinRenderGlobal_FixWordLeak.java
Outdated
Show resolved
Hide resolved
...ain/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinRenderGlobal_FixWordLeak.java
Show resolved
Hide resolved
tth05
force-pushed
the
effect-renderer-world-leak
branch
2 times, most recently
from
2d452c1 to
e878abe
Compare
Alexdoru
approved these changes
Nov 15, 2023
|
can you rebase your branch on top of master @tth05 |
tth05
force-pushed
the
effect-renderer-world-leak
branch
from
e878abe to
6c4b9ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.