Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to remove BOP warning #291

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Dec 6, 2023

No description provided.

@Caedis
Copy link
Member Author

Caedis commented Dec 6, 2023

@Dream-Master The default config will need to be updated for the pack to have this be enabled

Not needed anymore

@bombcar
Copy link
Member

bombcar commented Dec 6, 2023

Can the config "default true" if (coremod) or is that too complicated?

@mitchej123
Copy link
Contributor

@Caedis Feel free to add a dreamcraft detection and gate the feature based on that. I'd like to do that with some other things, once I figure out class loading order. It shouldn't be an issue here at all.

@Caedis
Copy link
Member Author

Caedis commented Dec 6, 2023

Can do

@Caedis Caedis enabled auto-merge (squash) December 6, 2023 16:18
@Caedis Caedis disabled auto-merge December 6, 2023 16:21
@Caedis Caedis merged commit 13c4e13 into master Dec 6, 2023
1 check passed
@Caedis Caedis deleted the fix/bopWarningConfig branch December 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants