Player Skin Fetching Fix part 2 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchej123
approved these changes
Dec 18, 2023
Dream-Master
pushed a commit
that referenced
this pull request
Dec 20, 2023
* set user agent on image download requests (cherry picked from commit 57b9a00)
|
Sorry for the trouble this has caused 😓 I would like to unblock Russia but I have no choice but to pay for all the bytes sent through the CDN, which includes errors, and the request volume is large enough even error pages are an issue. As the American holiday season comes to an end I'd like to try to find a better permanent solution to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visage (the service used by the skin fetching fix) recently changed to require a non-generic user agent in API requests due to an influx of spam requests. (run eg.
curl https://visage.surgeplay.com/skin/Notch.pngto get a message describing this in more detail)This sets a custom user agent for all requests made by
ThreadDownloadImageDatato satisfy this condition, currently formatted asMinecraft/1.7.10 Hodgepodge/2.3.40 (+https://github.com/GTNewHorizons/Hodgepodge)(Bonus: As of a couple minutes ago at the time of this PR, Visage is now also geoblocking requests from Russia due to that being where all the spam requests are coming from and no other good way to keep them from eating bandwidth etc)