Skip to content
This repository has been archived by the owner on May 25, 2024. It is now read-only.

Added a time to empty/time to full readout on the LSC #85

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

Reflex18
Copy link

@Reflex18 Reflex18 commented Apr 4, 2024

The readout displays the time to full or time to empty based on the average input and output of the eu into the lsc. The readout information is displayed in minutes as i felt it would be the easiest for the player to understand at a glance.

LSC.readout.mp4

Reflex18 added 2 commits April 4, 2024 22:09
Update GTMTE_LapotronicSuperCapacitor.java

Update GTMTE_LapotronicSuperCapacitor.java

Update GTMTE_LapotronicSuperCapacitor.java

Update GTMTE_LapotronicSuperCapacitor.java

Update GTMTE_LapotronicSuperCapacitor.java

Update GTMTE_LapotronicSuperCapacitor.java

Update GTMTE_LapotronicSuperCapacitor.java
@Dream-Master Dream-Master requested a review from a team April 4, 2024 15:26
Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cache getAvgIn() and getAvgOut() so that its not called several times here?

@Caedis
Copy link
Member

Caedis commented Apr 4, 2024

Close, but the variables need to be inside the method so that they are called each time.

Move them to after line 912

@Caedis
Copy link
Member

Caedis commented Apr 4, 2024

Looks like you need to run spotlessApply on it most likely.

@Dream-Master Dream-Master merged commit a5eb98a into GTNewHorizons:master Apr 5, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants