use buffer in LuaStateFactory file comparison #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickMG
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Nice catch. The change makes sense and it does save a precious few seconds of pack startup time!
Before: > 3s
[08:28:20] [Client thread/INFO] [OpenComputers]: Initializing OpenComputers API.
[08:28:21] [Client thread/INFO] [OpenComputers]: Found a compatible native library: 'OpenComputersMod-1.10.27-GTNH-nei-manual-offset-fix.1+1c446545d4-52-libjnlua52-windows-x86_64.dll'.
[08:28:22] [Client thread/INFO] [OpenComputers]: Found a compatible native library: 'OpenComputersMod-1.10.27-GTNH-nei-manual-offset-fix.1+1c446545d4-53-libjnlua53-windows-x86_64.dll'.
[08:28:23] [Client thread/INFO] [OpenComputers]: Found a compatible native library: 'OpenComputersMod-1.10.27-GTNH-nei-manual-offset-fix.1+1c446545d4-54-libjnlua54-windows-x86_64.dll'.
[08:28:23] [Client thread/INFO] [OpenComputers]: Done with pre init phase.
After : < 1s
[08:54:37] [Client thread/INFO] [OpenComputers]: Initializing OpenComputers API.
[08:54:37] [Client thread/INFO] [OpenComputers]: Found a compatible native library: 'OpenComputersMod-1.10.27-GTNH-fork-charagarlnad-master.1+fdccaa7d90-52-libjnlua52-windows-x86_64.dll'.
[08:54:37] [Client thread/INFO] [OpenComputers]: Found a compatible native library: 'OpenComputersMod-1.10.27-GTNH-fork-charagarlnad-master.1+fdccaa7d90-53-libjnlua53-windows-x86_64.dll'.
[08:54:37] [Client thread/INFO] [OpenComputers]: Found a compatible native library: 'OpenComputersMod-1.10.27-GTNH-fork-charagarlnad-master.1+fdccaa7d90-54-libjnlua54-windows-x86_64.dll'.
[08:54:37] [Client thread/INFO] [OpenComputers]: Done with pre init phase.
Dream-Master
pushed a commit
that referenced
this pull request
Dec 15, 2024
(cherry picked from commit 28fe621)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaStateFactory compares files using non-buffered, single byte reads. This PR wraps the FileInputStream in a BufferedInputStream to buffer reads.
before:
_root > Loading > PreInitialization > OpenComputers 4.757485(s)after:
_root > Loading > PreInitialization > OpenComputers 1.149008(s)