Fix Clearing Mages's Mace Equipped Flag #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mage's Mace focus damage is done on a tick update, so it sets a flag when the focus is equipped so that damage is only added once.
This was hard-coded to true which led to removing the focus causing the wand or staff to never be able to use the focus again.
This PR rewrites the hard-coded true to take the isActive function argument that was just going unused.
Tested in nightly 563 with no issues.
fixes GTNewHorizons/GT-New-Horizons-Modpack#16597