-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove restrictions to rename a tool in ToolStation #136
Conversation
Please run |
Seems like I forgot to disable the IntelliJ IDEA "Optimize Imports", which has been performed just before commit 😅 Disabled for good now 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should change it properly and not just switch that method to true while leaving dead code around it. That is if we actually want to change this.
I have to say I dont see why we would want to change this behaviour, it seems to work as intended. But I guess I don't really care.
Alright, I'll commit that tomorrow 👍 |
can you also say why you want to change this? |
No reason, it was simply in "ready for development" so I checked it out. Did think it was already approved or something to have the label. I may have misunderstood the meaning of the label. |
Not all tickets are correct ;) |
Closing PR as the change is not needed any more. Thanks @chochem, for the clarification. |
Close GTNewHorizons/GT-New-Horizons-Modpack#16035