Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] warnings #296

Open
mglisse opened this issue Apr 29, 2020 · 3 comments
Open

[python] warnings #296

mglisse opened this issue Apr 29, 2020 · 3 comments

Comments

@mglisse
Copy link
Member

mglisse commented Apr 29, 2020

I just discovered (yes, I should learn python properly...) https://docs.python.org/3/library/warnings.html . That seems like a good fit for print("Warning: computing barycenter of empty diag set. Returns None") in barycenter.py.

@tlacombe
Copy link
Contributor

tlacombe commented May 7, 2020

Noticed. I will do a PR incorporating soon.

@VincentRouvreau
Copy link
Contributor

VincentRouvreau commented Aug 16, 2023

List of warnings candidates:

@mglisse
Copy link
Member Author

mglisse commented Jul 25, 2024

As discussed in #1096:

  • if we stick to print, it makes sense to at least print to file=sys.stderr.
  • in addition to the warnings module, there is also https://docs.python.org/3/library/logging.html , which may be more appropriate for some of the messages (not necessarily all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants