Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use warnings python package to warn user instead of print('warning:...') #929

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Use warnings python package to warn user instead of print('warning:...') #929

merged 1 commit into from
Aug 16, 2023

Conversation

VincentRouvreau
Copy link
Contributor

@VincentRouvreau VincentRouvreau commented Aug 4, 2023 •
edited
Loading

Fix partially #296

@mglisse
Copy link
Member

mglisse commented Aug 11, 2023

Please rephrase the comment so github doesn't automatically close the issue. Most of our uses of print are wrong, although I didn't check which ones should be warnings and which ones errors (exceptions).

@VincentRouvreau VincentRouvreau merged commit 7ab5590 into GUDHI:master Aug 16, 2023
@VincentRouvreau VincentRouvreau deleted the barycenter_warning branch August 16, 2023 09:22
@VincentRouvreau VincentRouvreau added the 3.9.0 GUDHI version 3.9.0 label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglisse mglisse mglisse approved these changes

Assignees

@tlacombe tlacombe

Labels
3.9.0 GUDHI version 3.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentRouvreau @mglisse @tlacombe