Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support derivations with content-addressed outputs #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rickynils
Copy link

No description provided.

@sorki
Copy link
Collaborator

sorki commented Dec 7, 2023

Hi, there's some overlap here with #24 that allows you to do this as well in more type safe manner (without forcing you to use txt for hashes) (see also haskell-nix/hnix-store@641cd4f)

Your PR is handy since I wasn't sure how CA one looks exactly!

@rickynils
Copy link
Author

@sorki I did see your PR after I created mine and also realized there is some overlap. It was a coincidence that I happened to create my PR almost at the same time as yours, I was just going over some local patches we have in nixbuild.net :)

@sorki
Copy link
Collaborator

sorki commented Dec 7, 2023

Cool, I can integrate your changes after I'm done with it!

sorki pushed a commit to sorki/Haskell-Nix-Derivation-Library that referenced this pull request Dec 10, 2023
ConnorBaker added a commit to ConnorBaker/nix-output-monitor that referenced this pull request Jan 25, 2024
…rary fork

All credit goes to @sorki and @rickynils for their work on:

- Gabriella439/Haskell-Nix-Derivation-Library#26
- Gabriella439/Haskell-Nix-Derivation-Library#24

This commit takes the changes relevant to `Nix.Derivation` and vendors them in-tree.

Co-Authored-By: sorki <[email protected]>
Co-Authored-By: Rickard Nilsson <[email protected]>
ConnorBaker added a commit to ConnorBaker/nix-output-monitor that referenced this pull request Jan 25, 2024
…rary fork

All credit goes to @sorki and @rickynils for their work on:

- Gabriella439/Haskell-Nix-Derivation-Library#26
- Gabriella439/Haskell-Nix-Derivation-Library#24

and of course to @Gabriella439 for the entire library!

This commit takes the changes relevant to `Nix.Derivation` and vendors them in-tree.

Co-Authored-By: Gabriella Gonzalez <[email protected]>
Co-Authored-By: sorki <[email protected]>
Co-Authored-By: Rickard Nilsson <[email protected]>
ConnorBaker added a commit to ConnorBaker/nix-output-monitor that referenced this pull request Jan 25, 2024
…rary fork

All credit goes to @sorki and @rickynils for their work on:

- Gabriella439/Haskell-Nix-Derivation-Library#26
- Gabriella439/Haskell-Nix-Derivation-Library#24

and of course to @Gabriella439 for the entire library!

This commit takes the changes relevant to `Nix.Derivation` and vendors them in-tree.

Co-Authored-By: Gabriella Gonzalez <[email protected]>
Co-Authored-By: sorki <[email protected]>
Co-Authored-By: Rickard Nilsson <[email protected]>
ConnorBaker added a commit to ConnorBaker/nix-output-monitor that referenced this pull request Jan 25, 2024
…rary fork

All credit goes to @sorki and @rickynils for their work on:

- Gabriella439/Haskell-Nix-Derivation-Library#26
- Gabriella439/Haskell-Nix-Derivation-Library#24

and of course to @Gabriella439 for the entire library!

This commit takes the changes relevant to `Nix.Derivation` and vendors them in-tree.

Co-Authored-By: Gabriella Gonzalez <[email protected]>
Co-Authored-By: sorki <[email protected]>
Co-Authored-By: Rickard Nilsson <[email protected]>
@Ericson2314
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants