Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: try a purely compiled moffat init #140

Merged
merged 5 commits into from
Jan 30, 2025
Merged

perf: try a purely compiled moffat init #140

merged 5 commits into from
Jan 30, 2025

Conversation

beckermr
Copy link
Collaborator

This PR tries a moffat init that is compiled directly.

Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #140 will degrade performances by 62.87%

Comparing opt-moffat-init (c604a08) with main (7a2fffc)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_benchmark_moffat_init[compile] 186 ms 501 ms -62.87%
test_benchmark_moffat_init[run] 725.3 µs 408.3 µs +77.66%

jax_galsim/moffat.py Outdated Show resolved Hide resolved
@beckermr beckermr merged commit f2687db into main Jan 30, 2025
6 checks passed
@beckermr beckermr deleted the opt-moffat-init branch January 30, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant