allow only string and undefined in IsDifferentValue decorator

GalaChain · Mar 5, 2024 · 09c37b6 · 09c37b6
1 parent 2479706
commit 09c37b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 558 deletions.
diff --git a/chain-api/src/validators/decorators.ts b/chain-api/src/validators/decorators.ts
@@ -51,13 +51,10 @@ export function IsDifferentValue(property: string, validationOptions?: Validatio
           const [relatedPropertyName] = args.constraints;
           const relatedValue = args.object[relatedPropertyName];
           if (
-            typeof value === "object" ||
-            typeof value === "function" ||
-            typeof relatedValue === "object" ||
-            typeof relatedValue === "function" ||
-            typeof value !== typeof relatedValue
+            (typeof value !== "string" && value !== undefined) ||
+            (typeof relatedValue !== "string" && relatedValue !== undefined)
           ) {
-            throw new NotImplementedError("IsDifferentValue only works with plain objects");
+            throw new NotImplementedError("IsDifferentValue only works with string or undefined");
           }
           return value !== relatedValue;
         }