Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up docker buildx #114

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Set up docker buildx #114

merged 4 commits into from
Apr 11, 2024

Conversation

Fuerback
Copy link

This PR sets up the Docker Buildx to build and publish the docker images for all platforms.

@Fuerback Fuerback self-assigned this Mar 21, 2024
Comment on lines 134 to 136
- name: Checkout
uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it work without checkout?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read somewhere the checkout step wasn't necessary because docker/setup-buildx-action@v3 does that, but I'm not finding this information anymore and the example there uses checkout.
Going to restore it.

@Fuerback Fuerback merged commit b572f20 into main Apr 11, 2024
4 checks passed
@Fuerback Fuerback deleted the docker-buildx branch April 11, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants